-
-
Notifications
You must be signed in to change notification settings - Fork 185
Breakpad support for windows #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For me it is looks like duplicate of #278 But two things could be grabbed from this PR: https://github.com/getsentry/sentry-native/pull/290/files#diff-042142541573eb3944ddb1a697442a5dR80
is this required by MinGW? However, it may be due to unnecessary files in the project. https://github.com/getsentry/sentry-native/pull/290/files#diff-c013c7e9443f2c2d3c00e5b66ee9c33aR178
So, do not sure how it supposed to work for sentry-native. |
Given that there's no default on This could be similar to the system crash reporter setting for now, which only has an effect on the Crashpad backend: sentry-native/include/sentry.h Lines 838 to 839 in 19ad6e7
|
So in my PR I set it to register only |
@Mixaill the psapi requirement was actually due to extra code that I didn't include in this pr. We're currently using ming64 on linux, not via msys2, so were restricted to gcc, thus no pdbs. We process the dwarf debug data produced by gcc and append extra cv records to the minidump that contain the code_id generated via the .text checksum like how the linux fall back is working. This code needed GetModuleFileNameEx, but I'm actually going to be reworking it such that its not needed. |
@Mixaill Your pr looks about the same as mine, little more polished =). |
Closing this in favor of #278 |
Updates Breakpad backend to support windows.