test(logs): add 32-bit vargs test #1370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
supervacuus
requested changes
Sep 15, 2025
| test_param_conversion_helper( | ||
| "%lld %lld %lld", (long long)a, (long long)b, (long long)c); | ||
| #else | ||
| test_param_conversion_helper("%d %d %d", a, b, c); |
There was a problem hiding this comment.
This should have a comment that raises:
- it is still undefined behavior (i.e., incorrect, given we read these params as 64-bit values)
- it only works because the 64-bit ABI provides 8-byte slots for variadic arguments
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
supervacuus
approved these changes
Sep 15, 2025
tests/unit/test_logs.c
Outdated
Comment on lines
157
to
158
| // Currently, on 32-bit platforms, we need to cast to long long since the | ||
| // parameter conversion expects long long for %d/%i format specifiers |
There was a problem hiding this comment.
The comment is now out of sync with the code it is commenting on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog