Conversation
JPeer264
force-pushed
the
jp/remove-manual-updates
branch
from
9ff5f68 to
19ba4f9
Compare
Member
|
thanks for shipping it into the sdk @JPeer264 . Do we have a way to make sure we're not missing spans if we ship this? |
Member
|
gonna test in prod |
Member
Author
|
I actually also added an e2e test in our SDK that has almost the same setup: https://github.com/getsentry/sentry-javascript/blob/4770a494ca61240d4e7388fe292ec8d66166f8a0/dev-packages/e2e-tests/test-applications/cloudflare-mcp/src/index.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #652 we had to manually add the flush, which should actually be done by the Cloudflare SDK. This has now landed in
10.28.0(via this PR) and no manual flushing has to be done anymore.Just to be sure sure I verified on top if everything has been sent locally. This is a trace from my local deployment:
https://sentry-sdks.sentry.io/explore/traces/trace/434f1b1e8655444c875bce5c66645376/?fov=0%2C291&node=span-84a7a24ae593ee49&project=4510380305022976&source=traces&statsPeriod=15m&targetId=a505468e10176600×tamp=1764689933
I recommend to review this PR without whitespaces enabled.