feat: implement skills system for grouping and managing tools #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a comprehensive skills system that organizes MCP tools into logical groups and provides enhanced authorization control. Skills provide a higher-level abstraction for tool management and permission handling. Key Changes: - Add skills.ts with skill definitions and tool-to-skill mapping - Implement skillDefinitions.ts for MCP skill metadata generation - Add /api/skills endpoint to Cloudflare worker for skill discovery - Integrate skills into MCP server alongside existing tools - Add comprehensive permission system for skill-level access control - Update CLI to support --skills flag for filtering available skills - Add skill validation script to ensure mapping consistency - Add extensive documentation (authorization.md, skill-workflows.md) Technical Details: - Skills group related tools (e.g., "issues" skill includes find_issues, get_issue_details, update_issue) - Each skill has metadata: name, description, category, required permissions - Tools maintain explicit skill mappings for authorization checks - Server exposes both tools and skills for flexible client integration - Backward compatible - existing tool-only workflows continue to work Testing: - Add server-skills-integration.test.ts for MCP protocol compliance - Add skills.test.ts for skill system unit tests - Update existing tool tests to include skill mappings 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Code <noreply@anthropic.com>
Member
Author
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
213
to
219
| // Legacy fallback: Check scopes if not using skills | ||
| else if ( | ||
| grantedScopes && | ||
| tool.requiredScopes && | ||
| tool.requiredScopes.length > 0 | ||
| ) { | ||
| allowed = isToolAllowed(tool.requiredScopes, grantedScopes); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
Author
|
Big change, hopefully didnt miss anything, but seems to work well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a comprehensive skills system that organizes MCP tools into logical groups and provides enhanced authorization control. Skills provide a higher-level abstraction for tool management and permission handling.
Key Changes:
Technical Details:
Testing:
Refs #196
Fixes #611