Skip to content

feat: detect user from sanctum token #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 5, 2022
Merged

feat: detect user from sanctum token #542

merged 5 commits into from
Apr 5, 2022

Conversation

ankurk91
Copy link
Contributor

@ankurk91 ankurk91 commented Feb 5, 2022

Hi, @stayallive

Solves #539

todos

  • test
  • DRY

I will proceed on adding test if you like the approach.

@github-actions
Copy link

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@stayallive
Copy link
Collaborator

This seems like a fine approach :) Let me know if you get stuck!

@ankurk91
Copy link
Contributor Author

@stayallive
I could not find any tests against collecting PII or handling Authenticated event, please assist me here.

@ankurk91 ankurk91 marked this pull request as ready for review February 27, 2022 05:28
@stayallive
Copy link
Collaborator

stayallive commented Apr 5, 2022

I ended up changing a few bits around but should work just the same 👍

Thanks, and sorry this took so long!

@stayallive stayallive merged commit d96f79c into getsentry:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants