fix: check index is availability in method SentryHandler::handleBatch #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When flushing logrecords with the handleBatch method the code now checks if $highets['level'] is available before using it. fixes getsentry#514
wimulkeman
changed the title
stayallive
reviewed
Sep 28, 2021
In array_reduce the first arguments in the callback value holds the returned value from the last iteration. On initialization this first argument is equal to the third argument provided in the array_reduce instantiation. If no third argument is provided, as is in this case, the default value NULL is used. Therefore on the first run $highest is equal to NULL and does not have the index 'level' available. fixes getsentry#514 See https://www.php.net/manual/en/function.array-reduce.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When flushing logrecords with the handleBatch method the code now checks if $highets['level'] is available before using it.
fixes #514