Add sql.origin to SQL query spans
#398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
force-pushed
the
feature/add-sql-origin-to-query-tracing-span
branch
from
e763b2e to
d8b61a3
Compare
# Conflicts: # test/Sentry/Tracing/EventHandlerTest.php
# Conflicts: # src/Sentry/Laravel/Tracing/EventHandler.php # src/Sentry/Laravel/Tracing/ServiceProvider.php # test/Sentry/Tracing/EventHandlerTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
sql.originto the data of a SQL query tracing span which would contain the file path and line number from where to SQL query originated from in the code of the user.Why? So you can quickly see and or jump the the code where a potential problematic query is coming from instead of only seeing the query that was executed.
Disclaimer: This is a work in progress and possibly will only be merged after support in Sentry server is introduces for this, but nice to have a PoC and see if we can get some feedback on how to improve this or how to get the source line more efficiently.