Add more options to breadcrumbs configuration

[leo108]

Fixes #257

[leo108]

@stayallive any feedback on the PR?

[leo108]

@stayallive Is there any chance to look at this PR?

[stayallive]

Yeah I'm really sorry for ignoring you for this long.

I don't think this is the way to go, since this does not allow us (or Laravel) to ever make changes in the event names/types we want to watch for an operation.

There are also quite some other cases where right now it's needed that the EventHandler is registered no matter what since otherwise events when running a queue worker might never be sent.

How about we do something like you requested in your original request. Just allow for disabling the query breadcrumbs?

We already have:

    'breadcrumbs' => [
        // Capture bindings on SQL queries logged in breadcrumbs
        'sql_bindings' => true,
    ],

What about adding an option like for example:

    'breadcrumbs' => [
        // Log SQL queries as breadcrumbs
        'queries' => true,

        // Capture bindings on SQL queries logged in breadcrumbs
        'sql_bindings' => true,
    ],

This way we could keep adding options to disable built-in breadcrumb features without having to have a defined list of events in the user config.

[leo108]

@stayallive Thanks for the feedback, I'll check and update my PR.

[stayallive]

Many thanks for taking the time to do that!

[leo108]

@stayallive Please check again, thanks.

[leo108]

@HazAT Can you check this PR? thanks.

[nauxliu]

I would love to see this merged. How can we move forward on this PR?

[stayallive]

@nauxliu: @HazAT was just pinged a few short hours ago to leave his review, after he is done and there are no more "problems" found it should al go pretty quick.

It's being worked on!

Thank you (both) for your patience.

[HazAT]

Nice! Thank you!

Note: We should update our docs here: https://docs.sentry.io/platforms/php/laravel/#laravel-specific-options

GH:
https://github.com/getsentry/sentry-docs/blob/master/src/collections/_documentation/platforms/php/laravel.md#laravel-specific-options

cc @stayallive

[nauxliu]

Great! looks we are making a progress, Thank you all @leo108 @stayallive @HazAT

[stayallive]

Thanks again for your patience and working on this 👍