-
-
Notifications
You must be signed in to change notification settings - Fork 19
Fix IndexOutOfBounds
crash on iOS
#434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
buenaflor
merged 9 commits into
main
from
cursor/fix-sentry-kmp-stack-trace-crash-on-ios-f0c7
Jul 31, 2025
Merged
Fix IndexOutOfBounds
crash on iOS
#434
buenaflor
merged 9 commits into
main
from
cursor/fix-sentry-kmp-stack-trace-crash-on-ios-f0c7
Jul 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: giancarlo.buenaflor <giancarlo.buenaflor@sentry.io>
Co-authored-by: giancarlo.buenaflor <giancarlo.buenaflor@sentry.io>
@sentry review |
...form/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/nsexception/CommonAddressesTests.kt
Show resolved
Hide resolved
KotlinIndexOutOfBounds
crash on iOS
KotlinIndexOutOfBounds
crash on iOSIndexOutOfBounds
crash on iOS
markushi
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes an
IndexOutOfBoundsException
in thedropCommonAddresses
function when processing stack traces on Kotlin/Native iOS. The issue was caused by incorrect index handling during thedropLastWhile
operation.💡 Motivation and Context
Closes #432
💚 How did you test it?
Manually tested: the following test crashes without the fix with
IndexOutOfBoundsException
Existing unit tests were run to verify the fix and ensure no regressions.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps
Release this fix in an upcoming version to allow users to update their Sentry KMP dependency.
Learn more about Cursor Agents