Add stubs/no-op support for unsupported targets #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: giancarlo.buenaflor <giancarlo.buenaflor@sentry.io>
…for-sentry-kmp-235a
…s-browser-target-for-sentry-kmp-235a
buenaflor
changed the title
js and wasmJs target
buenaflor
changed the title
js and wasmJs target
buenaflor
changed the title
romtsn
approved these changes
Jul 21, 2025
romtsn
reviewed
Jul 21, 2025
| } | ||
|
|
||
| private fun KotlinMultiplatformExtension.addNoOpTargets() { | ||
| js(IR) { |
There was a problem hiding this comment.
oh, should we use BOTH here? https://kotlinlang.org/docs/js-ir-compiler.html#authoring-libraries-for-the-ir-compiler-with-backwards-compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this should not be merged before we fix craft to process the new targets
📜 Description
Users have bad devex if they use targets that we don't support.
Currently the SDK won't compile and the user would have to shift their sourceSet architecture which is unrealistic.
💡 Motivation and Context
Adds no-op support for
js,wasm-js,linux,mingwso users can freely use Sentry in the official supported targets and no-op targets.Closes #328
Closes #327
Closes #329