Skip to content

Add sample rate configuration #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Add sample rate configuration #144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9191dc3
Add sample rate configuration
buenaflor Nov 9, 2023
da27ded
fix formatting
buenaflor Nov 9, 2023
76f9e4d
run api dump
buenaflor Nov 9, 2023
70328c8
Set to NSNumber
buenaflor Nov 9, 2023
3695aae
Modify NSNumber usage
buenaflor Nov 9, 2023
5b1313d
Add another test
buenaflor Nov 9, 2023
2a4e822
Add changelog
buenaflor Nov 9, 2023
9e3bae0
Ignore file for detekt
buenaflor Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set to NSNumber
  • Loading branch information
@buenaflor
buenaflor committed Nov 9, 2023
commit 70328c82fc2a37a5554c9fb575f992fadeeb2c05
8 changes: 6 additions & 2 deletions ...pleMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryOptionsExtensions.apple.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,12 @@ internal fun CocoaSentryOptions.applyCocoaBaseOptions(options: SentryOptions) {
enableAutoSessionTracking = options.enableAutoSessionTracking
maxAttachmentSize = options.maxAttachmentSize.convert()
maxBreadcrumbs = options.maxBreadcrumbs.convert()
sampleRate = options.sampleRate as? NSNumber
tracesSampleRate = options.tracesSampleRate as? NSNumber
options.sampleRate?.let {
sampleRate = NSNumber(it)
}
options.tracesSampleRate?.let {
tracesSampleRate = NSNumber(it)
}
beforeSend = { event ->
val cocoaName = BuildKonfig.SENTRY_COCOA_PACKAGE_NAME
val cocoaVersion = BuildKonfig.SENTRY_COCOA_VERSION
Expand Down
1 change: 0 additions & 1 deletion ...multiplatform/src/commonAppleTest/kotlin/io/sentry/kotlin/multiplatform/FoundationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import kotlin.test.assertContentEquals
import kotlin.test.assertEquals

class FoundationTest {

@Test
fun `convert string to NSData and ByteArray is correct`() {
val text = "$!()I!(DKDASKDKSD(#(ldkiadjk91jd"
Expand Down
17 changes: 16 additions & 1 deletion ...n-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryOptionsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,25 @@
package io.sentry.kotlin.multiplatform

import io.sentry.kotlin.multiplatform.protocol.Breadcrumb
import io.sentry.kotlin.multiplatform.utils.fakeDsn
import kotlin.test.Test
import kotlin.test.assertEquals

class SentryOptionsTest {
class SentryOptionsTest : BaseSentryTest() {
@Test
fun `GIVEN sample rate WHEN set in Sentry init THEN does not crash`() {
// GIVEN
val sampleRate = 0.5

// WHEN
sentryInit {
it.dsn = fakeDsn
it.sampleRate = sampleRate
}

// THEN
// does not crash
}

@Test
fun `Breadcrumb can be modified via callback in init and should return the modified Breadcrumb`() {
Expand Down