Skip to content

ref(node): Refactor node integrations to functional syntax #9959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2024
Merged

ref(node): Refactor node integrations to functional syntax #9959

merged 1 commit into from
Jan 3, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 21, 2023

Getting there...

@mydea mydea requested review from Lms24 and AbhiPrasad December 21, 2023 15:53
@mydea mydea self-assigned this Dec 21, 2023
mydea
mydea commented Dec 21, 2023
View reviewed changes
packages/node/src/index.ts Outdated

import * as Handlers from './handlers';
import * as NodeIntegrations from './integrations';
import * as TracingIntegrations from './tracing/integrations';

const INTEGRATIONS = {
...CoreIntegrations,
...NodeIntegrations,
...(NodeIntegrations as {
Console: Integration;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS complains about this otherwise, somehow 😬 with TS4023: Exported Variable <x> has or is using name <y> from external module but cannot be named. No idea, but I think this is fine for now...

AbhiPrasad
AbhiPrasad approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like converting from react class components to functional components.

@mydea mydea force-pushed the fn/node-integrations-fn branch from 2643b46 to 5765909 Compare December 22, 2023 07:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.94 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.3 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.93 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.88 KB (+0.06% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.42 KB (0%)
@sentry/browser - Webpack (gzipped) 22.12 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 73.34 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 65.01 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.16 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.16 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 203.92 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 93.81 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 68.73 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.12 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.71 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped) 22.16 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.35 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.99 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.63 KB (0%)

@mydea mydea force-pushed the fn/node-integrations-fn branch from 3a6e9ae to 2c2b356 Compare December 22, 2023 08:57
@mydea mydea force-pushed the fn/node-integrations-fn branch 2 times, most recently from b58856e to 9c16a78 Compare January 2, 2024 15:14
@mydea mydea force-pushed the fn/node-integrations-fn branch from 9c16a78 to 9d70bd5 Compare January 3, 2024 08:30
@mydea mydea merged commit f127479 into develop Jan 3, 2024
@mydea mydea deleted the fn/node-integrations-fn branch January 3, 2024 09:41
anonrig pushed a commit that referenced this pull request Jan 3, 2024
@mydea @anonrig
ref(node): Refactor node integrations to functional syntax (#9959)
ce78b5b 
Getting there...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @AbhiPrasad