Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Pass client instead of hub to isSentryRequestUrl #9869

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 15, 2023

Step by step, eradicating the hub...

Note: I haven't found a way to mark an attribute type of a function as deprecated 😬 I think it's OK here, but generally a bit annoying/tricky...

@mydea mydea self-assigned this Dec 15, 2023
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.21 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.6 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.2 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.29 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.91 KB (0%)
@sentry/browser - Webpack (gzipped) 21.58 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.56 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.31 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.54 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.35 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.52 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.45 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.97 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped) 21.62 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.71 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.4 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.19 KB (0%)

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the biggest fan of using the hub | client union, I'd rather we just introduce a new function, but I'm fine with this change.

@mydea
Copy link
Member Author

mydea commented Dec 18, 2023

I'm not the biggest fan of using the hub | client union, I'd rather we just introduce a new function, but I'm fine with this change.

Yeah, I totally understand that, but I fear we'd just get into naming hell (e.g. how should this be called? ...) I fear we'll have a few more of these in the next days, but very soon we'll get rid of it all again 😅

@mydea mydea merged commit db4bef1 into develop Dec 18, 2023
93 checks passed
@mydea mydea deleted the fn/isSentryRequestUrl branch December 18, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants