Skip to content

chore(feedback): Adjust package resolutions for @sentry-internal/feedback in Remix and NextJS Integration tests #9733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 4, 2023

Exporting user feedback via @sentry/browser (#9586) broke Remix and NextJS integration tests because they rely on local package resolutions. I'm not sure why CI didn't catch this but it's currently blocking the 7.85.0 release.

This PR adds the missing entries and updates the "New SDK/Package Release Checklist". Adding a package that's. a dependency of these framework SDKs happens so rarely that we probably didn't come across this yet.

Once this is merged we need to sync develop into master and then we can try publishing again

@Lms24 Lms24 requested review from mydea and billyvg December 4, 2023 18:15
@Lms24 Lms24 requested review from c298lee and AbhiPrasad December 4, 2023 18:16
Copy link
Contributor

github-actions bot commented Dec 4, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.99 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 59.59 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.12 KB (0%)
@sentry/browser - Webpack (gzipped) 21.38 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.97 KB (+0.41% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.62 KB (+0.33% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.69 KB (+0.45% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 198.31 KB (+0.44% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 89.73 KB (+0.47% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 64.71 KB (+0.66% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.29 KB (+0.22% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.35 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped) 21.42 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.07 KB (+0.14% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.21 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.17 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 74.63 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.72 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 71.22 KB (added)

@billyvg
Copy link
Member

billyvg commented Dec 4, 2023

TIL about the checklist, great to know!

@billyvg
Copy link
Member

billyvg commented Dec 4, 2023

So I think what happened was that we were using an internal package version of feedback that was already published, and now we're releasing a new version (7.85.0), that has not been published.

@Lms24 Lms24 merged commit 2ae79fa into develop Dec 4, 2023
@Lms24 Lms24 deleted the lms/fix-feedback-integration-test-resolutions branch December 4, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants