Skip to content

fix(remix): Don't capture error responses that are not 5xx on Remix v2. #9655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix(remix): Don't capture error responses that are not 5xx on Remix v2. #9655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/remix/src/client/errors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ import type { ErrorResponse } from '../utils/vendor/types';
export function captureRemixErrorBoundaryError(error: unknown): string | undefined {
let eventId: string | undefined;
const isClientSideRuntimeError = !isNodeEnv() && error instanceof Error;
const isRemixErrorResponse = isRouteErrorResponse(error);
// We only capture `ErrorResponse`s that are 5xx errors.
const isRemixErrorResponse = isRouteErrorResponse(error) && error.status >= 500;
// Server-side errors apart from `ErrorResponse`s also appear here without their stacktraces.
// So, we only capture:
// 1. `ErrorResponse`s
Expand Down