Skip to content

test(overhead): Stop loading api.lorem.space images #8833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Aug 17, 2023

This site is dead, lets remove the image loading from it. Not sure if loading images is required for the overhead metrics though...

@billyvg billyvg requested a review from mydea August 17, 2023 12:47
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.19 KB (+0.46% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.17 KB (+0.2% 🔺)
@sentry/browser - Webpack (gzipped) 21.85 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.72 KB (+0.27% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.18 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.18 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.95 KB (+0.41% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.78 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.86 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.04 KB (+0.09% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.21 KB (+15.62% 🔺)
@sentry/react - Webpack (gzipped) 21.88 KB (+0.18% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.03 KB (+0.41% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.7 KB (+0.19% 🔺)

billyvg and others added 2 commits August 18, 2023 08:18
This site is dead, lets remove the image loading from it. Not sure if loading images is required for the overhead metrics though...
@mydea mydea force-pushed the test-overhead-metrics-remove-api-lorem-space-images branch from 8668386 to 4a5a2bb Compare August 18, 2023 06:26
@mydea mydea marked this pull request as ready for review August 18, 2023 06:26
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some static (licence free!) images instead, let's merge this and get this fixed 🚀

@mydea
Copy link
Member

mydea commented Aug 18, 2023

closing & reopening this in order to run the overhead test (sadly it currently only picks up the ci-overhead-metrics label when it is added to the PR at create time 😬 also something to think about...)

@mydea mydea closed this Aug 18, 2023
@mydea mydea reopened this Aug 18, 2023
@github-actions
Copy link
Contributor

Replay SDK metrics 🚀

Latest data for: 3b92636
  Plain +Sentry +Replay
Value Value Diff Ratio Value Diff Ratio
LCP 75.00 ms 64.39 ms -10.61 ms -14.15 % 65.39 ms -9.61 ms -12.81 %
CLS 0.25 ms 0.24 ms -0.01 ms -5.00 % 0.25 ms -0.00 ms -0.68 %
CPU 19.49 % 21.68 % +2.18 pp +11.20 % 39.55 % +20.06 pp +102.91 %
JS heap avg 3.83 MB 7.11 MB +3.28 MB +85.52 % 11.05 MB +7.22 MB +188.44 %
JS heap max 5.16 MB 8.69 MB +3.53 MB +68.41 % 14.93 MB +9.77 MB +189.34 %
netTx 0 B 360.12 kB +360.12 kB n/a 9.48 kB +9.48 kB n/a
netRx 0 B 41 B +41 B n/a 41 B +41 B n/a
netCount 0 1 +1 n/a 1 +1 n/a
netTime 0.00 ms 118.15 ms +118.15 ms n/a 72.60 ms +72.60 ms n/a

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Fri, 18 Aug 2023 07:15:06 GMT

@mydea mydea enabled auto-merge (squash) August 18, 2023 07:21
@mydea mydea merged commit 88611c7 into develop Aug 18, 2023
@mydea mydea deleted the test-overhead-metrics-remove-api-lorem-space-images branch August 18, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants