Skip to content

test(replay): Fix flakes from customEvents #8827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Aug 16, 2023

Force a flush after each click, otherwise its possible that we have a flush inbtween the 3 clicks.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.12 KB (+0.36% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.14 KB (+0.09% 🔺)
@sentry/browser - Webpack (gzipped) 21.82 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.73 KB (+0.27% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.18 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.18 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.89 KB (+0.38% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.78 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.86 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.04 KB (+0.09% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.3 KB (+0.39% 🔺)
@sentry/react - Webpack (gzipped) 21.85 KB (+0.03% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.94 KB (+0.31% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.66 KB (+0.11% 🔺)

Force a flush after each click, otherwise its possible that we have a flush inbtween the 3 clicks.
@billyvg billyvg force-pushed the test-replay-fix-customEvents-flakey branch from 3279047 to 6dde6f2 Compare August 16, 2023 19:41
@billyvg billyvg marked this pull request as ready for review August 16, 2023 20:01
@billyvg billyvg requested a review from mydea August 16, 2023 20:01
@billyvg billyvg merged commit ff26887 into develop Aug 17, 2023
@billyvg billyvg deleted the test-replay-fix-customEvents-flakey branch August 17, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants