fix(utils): dirname and basename should handle Windows paths#8737
Merged
AbhiPrasad merged 3 commits intogetsentry:developfrom Aug 8, 2023
Merged
fix(utils): dirname and basename should handle Windows paths#8737AbhiPrasad merged 3 commits intogetsentry:developfrom
dirname and basename should handle Windows paths#8737AbhiPrasad merged 3 commits intogetsentry:developfrom
Conversation
mydea
reviewed
Aug 7, 2023
lforst
reviewed
Aug 7, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Truncate files names greater than 1024 characters to avoid regex dos | ||
| // https://github.com/getsentry/sentry-javascript/pull/8737#discussion_r1285719172 | ||
| const truncated = filename.length > 1024 ? `<truncated>${filename.slice(-1024)}` : filename; | ||
| const parts = splitPathRe.exec(truncated); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
lforst
approved these changes
Aug 7, 2023
AbhiPrasad
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Electron SDK uses
basenameto get the file name without path but this returned the full path on Windows.This PR adds Windows support to the regex and adds some tests.