Retry-After is returned in seconds, not ms #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
approved these changes
Feb 22, 2017
|
LGTM. I also wanted to be sure that sentry server actually follows the header convention and does seconds; you probably know it does off hand but I found that code path in the rate limiting stuff and verified. |
|
@mattrobenolt – can you confirm we return seconds? |
|
They did confirm for me in Slack.
…On Feb 22, 2017 6:05 PM, "Ben Vinegar" ***@***.***> wrote:
@mattrobenolt <https://github.com/mattrobenolt> – can you confirm we
return seconds?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#862 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAG2MW8AHGFhhVodbghBCTnlbnKHEsBks5rfM1TgaJpZM4MJCqW>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #860
cc @bretthoerner @getsentry/javascript