Skip to content

feat(replay): Remove unused debug statements #8167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2023
Merged

feat(replay): Remove unused debug statements #8167

merged 2 commits into from
May 25, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented May 19, 2023

These debug statements are not really providing value, removing them...

@billyvg
feat(replay): Remove unused debug statements
8938e6e 
These debug statements are not really providing value, removing them...
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.03 KB (+0.06% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.68 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.59 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.15 KB (+0.12% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.2 KB (+0.15% 🔺)
@sentry/browser - Webpack (minified) 69.07 KB (+0.05% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.22 KB (+0.16% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.16 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.67 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.9 KB (+0.1% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 48.24 KB (+1.32% 🔺)
@sentry/replay - Webpack (gzipped + minified) 41.95 KB (+1.19% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 67.21 KB (+1.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.11 KB (+1.23% 🔺)

@billyvg billyvg marked this pull request as ready for review May 23, 2023 18:05
@billyvg billyvg requested a review from Lms24 May 24, 2023 17:20
@billyvg billyvg merged commit 3f31b3d into develop May 25, 2023
@billyvg billyvg deleted the feat-replay-remove-debug-statement branch May 25, 2023 12:48
@billyvg billyvg added the Package: replay Issues related to the Sentry Replay SDK label May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billyvg @lforst @Lms24