fix(tracing): Don't set method multiple times #8014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
abhi-fix-nextjs-fetch-test
branch
from
e1a4f77 to
76f5398
Compare
mydea
approved these changes
May 2, 2023
Lms24
approved these changes
May 2, 2023
size-limit report 📦
|
AbhiPrasad
commented
May 2, 2023
| # Next.js v13 requires at least Node v14 | ||
| if [ "$NODE_MAJOR" -lt "14" ] && [ "$NEXTJS_VERSION" -ge "13" ]; then | ||
| # Next.js v13 requires at least Node v16 | ||
| if [ "$NEXTJS_VERSION" -ge "16" ] && [ "$NEXTJS_VERSION" -ge "15" ] && [ "$NODE_MAJOR" -lt "14" ] && [ "$NEXTJS_VERSION" -ge "13" ]; then |
There was a problem hiding this comment.
AbhiPrasad
commented
May 3, 2023
| "testCommand": "pnpm test:dev" | ||
| } | ||
| ], | ||
| "tests": [], |
There was a problem hiding this comment.
For now we disable these tests, we can re-add once we fix them.
billyvg
pushed a commit
that referenced
this pull request
May 5, 2023
Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix nextjs tests (not sure how they snuck into develop branch).
Instead of blindly spreading
handlerData.fetchDatawe explicitly take the url and method.