Skip to content

feat(node): Sanitize URLs in Span descriptions and breadcrumbs #7667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 30, 2023
Merged

feat(node): Sanitize URLs in Span descriptions and breadcrumbs #7667

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f8c5a6f
feat(pii) Sanitize URLs in Span descriptions and breadcrumbs
aldenquimby Feb 16, 2023
e57ff25
Reviewer suggestion
aldenquimby Feb 17, 2023
ad72855
Refer to official docs, not a PR
aldenquimby Feb 17, 2023
a1126b4
Filter authority
aldenquimby Feb 17, 2023
98c3a58
Updates from code review
aldenquimby Mar 15, 2023
2f70b17
Merge branch 'develop' into develop
aldenquimby Mar 15, 2023
63a7dec
Update packages/node/src/integrations/utils/http.ts
Lms24 Mar 29, 2023
c978afe
update jsdoc and comment
Lms24 Mar 30, 2023
6923118
Merge branch 'develop' into lms/node-sanitize-span-descr-breadcrumbs
Lms24 Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/node/src/integrations/utils/http.ts
  • Loading branch information
@Lms24
Lms24 authored Mar 29, 2023
commit 63a7decd93e39c6006249cdbda74edc018938b78
3 changes: 0 additions & 3 deletions packages/node/src/integrations/utils/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ export function isSentryRequest(url: string): boolean {
return dsn ? url.includes(dsn.host) : false;
}

/**
* @deprecated Please use extractUrl instead. Only exists for backwards compatability as we sanitize spans and breadcrumbs.
*/
export function extractRawUrl(requestOptions: RequestOptions): string {
const protocol = requestOptions.protocol || '';
const hostname = requestOptions.hostname || requestOptions.host || '';
Expand Down