Skip to content

Add return type for showReportDialog #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2016

Conversation

ilya-pirogov
Copy link
Contributor

@ilya-pirogov ilya-pirogov commented Aug 31, 2016

Typescript with noImplicitReturns option doesn't work.

ERROR in /home/ilya/test-project/node_modules/raven-js/typescript/raven.d.ts
(214,5): error TS7010: 'showReportDialog', which lacks return-type annotation, implicitly has an 'any' return type.

This change is Reviewable

@arusakov
Copy link

arusakov commented Sep 2, 2016

I faced this problem before.
I think, that every library with own .d.ts files must compile TS with all flags, with max checking.

noImplicitAny for this case.

node_modules/typescript/bin/tsc --noEmit --noImplicitAny typescript/raven-tests.ts

@ilya-pirogov Can you improve PR by this way?

@ilya-pirogov
Copy link
Contributor Author

@arusakov Done. How does it look now?

@arusakov
Copy link

arusakov commented Sep 6, 2016

👍

@VStas
Copy link

VStas commented Sep 6, 2016

Same problem here. I'm waiting for this PR.

@benvinegar
Copy link
Contributor

Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@benvinegar benvinegar merged commit cf2ddee into getsentry:master Sep 6, 2016
denstepa pushed a commit to denstepa/raven-js that referenced this pull request Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants