Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): Use Sentry's forked rrweb packages #6935

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 25, 2023

As outlined in getsentry/rrweb#15, we're now releasing packages of our rrrweb fork. This PR:

  • replaces the original rrweb dependency with our forked one
  • removes the patches for the original rrweb dependency which we now don't need anymore
  • removes the patch-package dev dependency, as we're not patching any package anymore

In terms of building the rrweb package, nothing changes. We're still inlining the rrweb code. IMO this is fine (especially after #6817) and we shouldn't change it.

@Lms24 Lms24 marked this pull request as ready for review January 25, 2023 19:21
@Lms24 Lms24 requested review from mydea and billyvg January 25, 2023 19:21
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@Lms24 Lms24 merged commit 67fec37 into master Jan 26, 2023
@Lms24 Lms24 deleted the lms-use-forked-rrweb branch January 26, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants