fix(replay): Send dsn in envelope header if tunneling is enabled
#6568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Dec 16, 2022
Comment on lines
+924
to
+926
| const dsn = client?.getDsn(); | ||
|
|
||
| if (!client || !scope || !transport) { | ||
| if (!client || !scope || !transport || !dsn) { |
There was a problem hiding this comment.
just adding this here so we can be certain, dsn isn't undefined further below. In case we don't have a dsn, we can't send anything anyway.
Lms24
changed the title
dsn in envelope header if tunneling is activedsn in envelope header if tunneling is enabled
size-limit report 📦
|
lforst
approved these changes
Dec 16, 2022
|
Going to merge this in to unblock our next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #6539, we're right now not sending the
dsnkey in the replay event envelope header, thereby not including the necessary information to forward the event to Sentry.This PR fixes that by extracting the
createEventEnvelopeHeadersfunction to utils so that we can use it in Replay (analogously to #6514), as well as using this function to create all headers.We tested this PR with NextJS'
tunnelRouteas well as with the conventionaltunneloption and everything seems to work now.Note: While refactoring and adding tests, I discovered that right now, replay event envelopes always contain the identical
replayIdasevent_idandreplay_id. Not sure if this is intended but I'm not changing this in this PR (cc @billyvg).fixes #6539