Skip to content

3.2.0 #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2016
Merged

3.2.0 #641

merged 1 commit into from
Jul 5, 2016

Conversation

benvinegar
Copy link
Contributor

@@ -1,5 +1,10 @@
# Changelog

## 3.2.0
* CHANGE: Callbacks set via `setDataCallback`, `setShouldSendCallback` now receive any prior-set callback as the 2nd argument. See: https://github.com/getsentry/raven-js/pull/636
* CHANGE: Raven.js no longer passes a 'message' interface for exceptions. See: https://github.com/getsentry/raven-js/pull/632
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely worth mentioning version compatibility with Sentry server. Doesn't this change bump the server requirement to 8.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't even realize that was a server change. Hmm, what's the right move here given that this could be breaking for on-premise users. Do we go to a full version bump (4.0.0)?

cc @dcramer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, does this mean the server will reject the event? Or just complain that the message interface is missing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure off hand, that's just why I raised the question. It may be completely fine, I just don't know without investigating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcramer says this is fine.

@benvinegar benvinegar merged commit aeac6ce into master Jul 5, 2016
@benvinegar benvinegar deleted the 3.2.0 branch July 5, 2016 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants