3.2.0 #641
Merged
3.2.0 #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## 3.2.0 | ||
| * CHANGE: Callbacks set via `setDataCallback`, `setShouldSendCallback` now receive any prior-set callback as the 2nd argument. See: https://github.com/getsentry/raven-js/pull/636 | ||
| * CHANGE: Raven.js no longer passes a 'message' interface for exceptions. See: https://github.com/getsentry/raven-js/pull/632 |
Contributor
There was a problem hiding this comment.
This is likely worth mentioning version compatibility with Sentry server. Doesn't this change bump the server requirement to 8.6?
Contributor
Author
There was a problem hiding this comment.
Oh, I didn't even realize that was a server change. Hmm, what's the right move here given that this could be breaking for on-premise users. Do we go to a full version bump (4.0.0)?
cc @dcramer
Contributor
Author
There was a problem hiding this comment.
Also, does this mean the server will reject the event? Or just complain that the message interface is missing?
Contributor
There was a problem hiding this comment.
I'm not entirely sure off hand, that's just why I raised the question. It may be completely fine, I just don't know without investigating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mattrobenolt