-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
3.1.0 #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.1.0 #611
Conversation
@@ -1,5 +1,8 @@ | |||
# Changelog | |||
|
|||
## 3.1.0 | |||
* NEW: Added TypeScript declaration file for compatibility with TypeScript projects. See: https://github.com/getsentry/raven-js/pull/610 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are obviously more changes here.
My first impression was "why are we doing a big version bump just for adding TS declarations", then realized there are lots of things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the bigger breaking change that we remove the ability to fetch context from the client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already removed that in 3.0.0 – it's in the changelog. We just removed extra extraneous code that we missed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first impression was "why are we doing a big version bump just for adding TS declarations", then realized there are lots of things.
If "big" is "minor version", then yes. It's not a bug fix / patch. It's a forward-compatible API change (if you use TypeScript).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm torn. That, to me, falls under something like, us adding a feature into a plugin. Does that mandate a minor version bump for something that affects a small % of users? I dunno.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That, to me, falls under something like, us adding a feature into a plugin.
That should be a minor bump too, yeah. It's an argument for moving these into their own repo.
😐 |
😅 |
cc @mattrobenolt