-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otel): Add initial package for otel #6002
Conversation
87aa39f
to
5cd1925
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I like the idea of having this in its own package. Just had a two remarks/questions.
Another question: Do you see any problems with the approach of the Otel package requiring sentry/tracing? I'm thinking for example about our long-term plan of splitting up or integrating the tracing package into browser/node so that users only have to install one package anymore.
Discussed this offline - the answer is: yes it might have consequences, but for now not going to worry about it until v8. |
size-limit report 📦
|
ref: #6000
Add boilerplate package for OpenTelemetry Node.
I would like to make this a separate package because we are dependent on the https://github.com/open-telemetry/opentelemetry-js-api, and I don't want to include that as a dependency for everyone else.
The nice thing is that we can require the usage of
@sentry/tracing
, so users only have to install@sentry/opentelemetry-node
! Aka either use@sentry/tracing
OR use@sentry/opentelemetry-node
.As such, installation looks like so: