Attempt to parse error name when no 5th error arg (fixes #535) #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| window.onerror = function(message) { | ||
| if (message == testMessage) { | ||
| window.onerror = function(message, url, lineNo) { | ||
| if (message == testMessage || lineNo === 1337) { |
There was a problem hiding this comment.
Oh, ignore me. This is a fixture.
There was a problem hiding this comment.
So, this relied on passing a unique message to prevent bubbling to mocha's onerror ...
But, my tests send custom messages. So I made it additionally accept a unique integer.
benvinegar
force-pushed
the
no-undefined-name
branch
from
e9f2ab6 to
0699859
Compare
|
cc @mattrobenolt – mind poking at the latest diff |
| name = groups[1]; | ||
| msg = groups[2]; | ||
| } | ||
| } catch (e) {} |
There was a problem hiding this comment.
What could explode here?
There was a problem hiding this comment.
It's not guaranteed message is a string. I could verify that though.
benvinegar
force-pushed
the
no-undefined-name
branch
from
0699859 to
31495ec
Compare
|
|
benvinegar
added a commit
that referenced
this pull request
Mar 22, 2016
Attempt to parse error name when no 5th error arg (fixes #535)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve exception data from Android Browser 4 - 4.3,
IE 8 and IE 9.I'm sure the regex is pretty naive and needs some looking over.
cc @mattrobenolt
Correction: While IE8 and IE9 don't support a 5th error argument for
onerror, their error messages don't contain the error type. For example, IE9 says'foo' is undefinedand omits any mention ofReferenceError.