Skip to content

[v7] feat: Drop support for Node 6 #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2022
Merged

[v7] feat: Drop support for Node 6 #4851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62e6320
feat(build): Drop support for Node 6
AbhiPrasad Apr 4, 2022
d3bf433
test(node): Remove Node 6 conditional
AbhiPrasad Apr 4, 2022
1045a1c
ref(build): Remove Node 6 condition
AbhiPrasad Apr 4, 2022
ca0c456
feat: Upgrade package.json engine to Node 8
AbhiPrasad Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [6, 8, 10, 12, 14, 16]
node: [8, 10, 12, 14, 16]
steps:
- name: Check out current commit (${{ env.HEAD_COMMIT }})
uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "MIT",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/browser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "BSD-3-Clause",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "build/dist/index.js",
"module": "build/esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "BSD-3-Clause",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"sentry"
],
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "src/index.js",
"publishConfig": {
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"sentry"
],
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "src/index.js",
"publishConfig": {
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"gatsby-plugin"
],
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/hub/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "BSD-3-Clause",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/integrations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "BSD-3-Clause",
"engines": {
"node": ">=6"
"node": ">=8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/minimal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "BSD-3-Clause",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "MIT",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "./dist/index.server.js",
"module": "./esm/index.server.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "BSD-3-Clause",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
4 changes: 1 addition & 3 deletions packages/node/test/integrations/http.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ describe('tracing', () => {

http.get('http://dogs.are.great/');

// TODO: For some reason in node 6 two request spans are appearing. Once we stop testing against it, this can go
// back to being `toEqual()`.
expect(spans.length).toBeGreaterThanOrEqual(2);
expect(spans.length).toEqual(2);

// our span is at index 1 because the transaction itself is at index 0
expect(spans[1].description).toEqual('GET http://dogs.are.great/');
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "BSD-3-Clause",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/tracing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "MIT",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "BSD-3-Clause",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "BSD-3-Clause",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "MIT",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/wasm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"author": "Sentry",
"license": "MIT",
"engines": {
"node": ">=6"
"node": ">=8"
},
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
16 changes: 1 addition & 15 deletions scripts/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,7 @@ function run(cmd: string, cwd: string = '') {

const nodeMajorVersion = parseInt(process.version.split('.')[0].replace('v', ''), 10);

// control which packages we test on each version of node
if (nodeMajorVersion <= 6) {
// install legacy versions of packages whose current versions don't support node 6
// ignoring engines and scripts lets us get away with having incompatible things installed for packages we're not testing
run('yarn add --dev --ignore-engines --ignore-scripts nock@10.x', 'packages/node');
run('yarn add --dev --ignore-engines --ignore-scripts jsdom@11.x', 'packages/tracing');
run('yarn add --dev --ignore-engines --ignore-scripts jsdom@11.x', 'packages/utils');

// only test against @sentry/node and its dependencies - node 6 is too old for anything else to work
const scope = ['@sentry/core', '@sentry/hub', '@sentry/minimal', '@sentry/node', '@sentry/utils', '@sentry/tracing']
.map(dep => `--scope="${dep}"`)
.join(' ');

run(`yarn test ${scope}`);
} else if (nodeMajorVersion <= 8) {
if (nodeMajorVersion <= 8) {
// install legacy versions of packages whose current versions don't support node 8
// ignoring engines and scripts lets us get away with having incompatible things installed for packages we're not testing
run('yarn add --dev --ignore-engines --ignore-scripts jsdom@15.x', 'packages/tracing');
Expand Down