Skip to content

Fix bad level arg in console plugin, other fixes - #474

Merged
benvinegar merged 1 commit into
masterfrom
fix-console-plugin
Jan 16, 2016
Merged

Fix bad level arg in console plugin, other fixes#474
benvinegar merged 1 commit into
masterfrom
fix-console-plugin

Conversation

@benvinegar

Copy link
Copy Markdown
Contributor

Started by applying #473 to plugins/console, then wrote some tests and found some other bugs:

  • level (passed to Sentry) was always undefined (closure bug)
  • Was only taking first argument from console methods to build message string (now joins with space character ' ')

benvinegar added a commit that referenced this pull request Jan 16, 2016
Fix bad level arg in console plugin, other fixes
@benvinegar
benvinegar merged commit 17c029c into master Jan 16, 2016
@benvinegar
benvinegar deleted the fix-console-plugin branch January 21, 2016 00:41
pull Bot pushed a commit to TheDegenerateDev5150/sentry-javascript that referenced this pull request Jun 19, 2026
* ref(component-annotate): Prefix plugin name with `babel`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant