Skip to content

fix(vue): Check if route name is defined before casting #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2022
Merged

fix(vue): Check if route name is defined before casting #4530

merged 1 commit into from
Feb 10, 2022

Conversation

AbhiPrasad
Copy link
Member

Ref: #4483

to.name can be undefined, so we should guard against it.

@AbhiPrasad
fix(vue): Check if route name is defined before casting
96598a8 
Ref: #4483

`to.name` can be undefined, so we should guard against it
@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and lobsterkatie and removed request for a team February 9, 2022 18:06
@AbhiPrasad AbhiPrasad mentioned this pull request Feb 9, 2022
Merged
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

size-limit report

Path Base Size (5df78df) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.77 KB 19.77 KB +0.02% 🔺
@sentry/browser - ES5 CDN Bundle (minified) 63.17 KB 63.18 KB +0.01% 🔺
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.51 KB 18.51 KB +0.02% 🔺
@sentry/browser - ES6 CDN Bundle (minified) 56.8 KB 56.8 KB +0.01% 🔺
@sentry/browser - Webpack (gzipped + minified) 22.21 KB 22.21 KB 0%
@sentry/browser - Webpack (minified) 76.02 KB 76.02 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.24 KB 22.24 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.31 KB 46.31 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.32 KB 28.33 KB +0.02% 🔺

@AbhiPrasad AbhiPrasad merged commit a547883 into master Feb 10, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-vue-name-undefined branch February 10, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @lobsterkatie