Skip to content

ref(ember): Remove logic that force passes ember tests #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ref(ember): Remove logic that force passes ember tests #3731

wants to merge 1 commit into from

Conversation

ahmedetefy
Copy link
Contributor

Removes patch transaction spans that was added to force pass the ember CI tests

@ahmedetefy ahmedetefy requested a review from kamilogorek as a code owner June 22, 2021 14:54
@ahmedetefy ahmedetefy mentioned this pull request Jun 22, 2021
Merged
kamilogorek
kamilogorek approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21 KB (-0.01% 🔽)
@sentry/browser - Webpack 21.94 KB (0%)
@sentry/react - Webpack 21.97 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.4 KB (0%)

@ahmedetefy ahmedetefy closed this Jun 22, 2021
@kamilogorek kamilogorek deleted the ahmed-ember-flakiness branch June 23, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmedetefy @kamilogorek