Skip to content

ref: Use esm imports with localforage and add esModuleInterop #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2021
Merged

ref: Use esm imports with localforage and add esModuleInterop #3403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/integrations/src/offline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
import { Event, EventProcessor, Hub, Integration } from '@sentry/types';
import { getGlobalObject, logger, normalize, uuid4 } from '@sentry/utils';
import * as localForageType from 'localforage';
import localForage from 'localforage';

// eslint-disable-next-line @typescript-eslint/no-var-requires
const localForage = require('localforage');
/**
* cache offline errors and send when connected
*/
Expand Down Expand Up @@ -38,7 +36,7 @@ export class Offline implements Integration {
/**
* event cache
*/
public offlineEventStore: typeof localForageType; // type imported from localforage
public offlineEventStore: typeof localForage;

/**
* @inheritDoc
Expand Down
1 change: 1 addition & 0 deletions packages/integrations/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"declarationMap": false,
"esModuleInterop": true,
"baseUrl": ".",
"outDir": "dist",
"types": ["node"]
Expand Down
1 change: 1 addition & 0 deletions packages/integrations/tsconfig.esm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": "../../tsconfig.esm.json",
"compilerOptions": {
"declarationMap": false,
"esModuleInterop": true,
"baseUrl": ".",
"outDir": "esm",
"types": ["node"]
Expand Down
1 change: 0 additions & 1 deletion packages/integrations/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"include": ["src/**/*.ts", "test/**/*.ts"],
"exclude": ["dist"],
"compilerOptions": {
"esModuleInterop": true,
"declarationMap": false,
"rootDir": ".",
"types": ["node", "jest"]
Expand Down