Skip to content

fix(mongo): Remove aggregate from operations whose arguments get serialized #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2020
Merged

fix(mongo): Remove aggregate from operations whose arguments get serialized #3102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1600cfb
remove aggregate in favor of comment
lobsterkatie Dec 4, 2020
64f8ffd
add link to PR
lobsterkatie Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/tracing/src/integrations/mongo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ const OPERATIONS = [
const OPERATION_SIGNATURES: {
[op in Operation]?: string[];
} = {
aggregate: ['pipeline'],
// aggregate intentionally not included because `pipeline` arguments are too complex to serialize well
// see https://github.com/getsentry/sentry-javascript/pull/3102
bulkWrite: ['operations'],
countDocuments: ['query'],
createIndex: ['fieldOrSpec'],
Expand Down