Skip to content

fix: Revert bad string replacements #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rhcarvalho
Copy link
Contributor

Fixes changes introduced in 8c60b1e.

Global string replacement was too eager and broke things in raven-node (although development head is actually in the 4.x branch). Other than that, this commit fixes doc comments and an entry in packages/typescript/package.json.

Fixes changes introduced in 8c60b1e.
Global string replacement was too eager and broke things in raven-node
(although development head is actually in the 4.x branch). Other than
that, this commit fixes doc comments and an entry in
packages/typescript/package.json.
@rhcarvalho rhcarvalho requested a review from HazAT March 25, 2020 10:05
@rhcarvalho rhcarvalho requested a review from kamilogorek as a code owner March 25, 2020 10:05
@@ -6,7 +6,7 @@
"homepage": "https://github.com/getsentry/raven-js/tree/master/packages/typescript",
"author": "Sentry",
"license": "BSD-3-Clause",
"private _": false,
"private": false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was broken for quite some time, is this key actually relevant? Isn't "private": false the default?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

@@ -21,7 +21,7 @@ interface SentryGlobal {
}

/**
* Requires a module which is protected _against bundler minification.
* Requires a module which is protected against bundler minification.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what got me started... I thought "why _against?!". The rest is Git history.

@rhcarvalho
Copy link
Contributor Author

Lint failure was introduced in #2510, broken in master it seems.

https://travis-ci.com/github/getsentry/sentry-javascript/jobs/302473023

@rhcarvalho
Copy link
Contributor Author

This is the failed build from #2510: https://travis-ci.com/github/getsentry/sentry-javascript/jobs/301043705

@kamilogorek what would you suggest here, a // tslint: comment or is there something better to take out of the linter output?

@sentry/utils: /home/travis/build/getsentry/sentry-javascript/packages/utils/src/supports.ts:109:14
355@sentry/utils: ERROR: 109:14  strict-type-predicates  Expression is always true.
356@sentry/utils: ERROR: 109:21  no-unbound-method       Avoid referencing unbound methods which may cause unintentional scoping of 'this'.
357@sentry/utils: ERROR: 109:25  deprecation             createElement is deprecated.

@rhcarvalho
Copy link
Contributor Author

Merged with master to pick up changes that should fix the lint error.

@rhcarvalho
Copy link
Contributor Author

All the new failures (all builds in the job):

@sentry/types: src/index.ts:16:25 - error TS2307: Cannot find module './runtime'.
@sentry/types: 16 export { Runtime } from './runtime';
@sentry/types:                            ~~~~~~~~~~~

@kamilogorek
Copy link
Contributor

Fixed and merged manually

@rhcarvalho rhcarvalho deleted the private-underscore branch March 25, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants