-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: Revert bad string replacements #2513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes changes introduced in 8c60b1e. Global string replacement was too eager and broke things in raven-node (although development head is actually in the 4.x branch). Other than that, this commit fixes doc comments and an entry in packages/typescript/package.json.
@@ -6,7 +6,7 @@ | |||
"homepage": "https://github.com/getsentry/raven-js/tree/master/packages/typescript", | |||
"author": "Sentry", | |||
"license": "BSD-3-Clause", | |||
"private _": false, | |||
"private": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this was broken for quite some time, is this key actually relevant? Isn't "private": false
the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct
@@ -21,7 +21,7 @@ interface SentryGlobal { | |||
} | |||
|
|||
/** | |||
* Requires a module which is protected _against bundler minification. | |||
* Requires a module which is protected against bundler minification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what got me started... I thought "why _against?!". The rest is Git history.
Lint failure was introduced in #2510, broken in master it seems. https://travis-ci.com/github/getsentry/sentry-javascript/jobs/302473023 |
This is the failed build from #2510: https://travis-ci.com/github/getsentry/sentry-javascript/jobs/301043705 @kamilogorek what would you suggest here, a
|
Merged with master to pick up changes that should fix the lint error. |
All the new failures (all builds in the job):
|
Fixed and merged manually |
Fixes changes introduced in 8c60b1e.
Global string replacement was too eager and broke things in raven-node (although development head is actually in the 4.x branch). Other than that, this commit fixes doc comments and an entry in
packages/typescript/package.json
.