Add plugin for Backbone.js.

[DouweM]

No description provided.

[mattrobenolt]

I will trust that this works. :)

Does it just need to be included on the page and it'll automatically patch things? Or does it need to be explicitly injected somehow? Angular plugin, for example, needs to be registered into the application before it can be used.

[DouweM]

Just include this in the page this after Raven and Backbone and you should be fine.

I've tested it with our fairly large Backbone app and it seems to work great. It's possible I've forgotten to cover some edge cases, but it definitely shouldn't break anything.

[mattrobenolt]

Can you confirm that I didn't break it with bdda4e9 ?

[DouweM]

The function builder looks nicer, but you broke it! Watch closely what happens with callback, _callback and callback._callback. Raven.wrap() should still wrap callback and oldOn should be called with the new wrapped callback.

[DouweM]

Fixed version:

function makeBackboneEventsOn(oldOn) {
  return function BackboneEventsOn(name, callback, context) {
    var _callback = callback._callback || callback;
    callback = Raven.wrap(callback);
    callback._callback = _callback;

    return oldOn.call(this, name, callback, context);
  };
}

I went the verbose if/else way because of the jquery plugin btw, not because I preferred it, but this case is somewhat more straight forward than the one in the jquery plugin.

[mattrobenolt]

Ohh, haha, I see what I did. One sec.

[mattrobenolt]

See: 7aec844

Sorry, I was cleaning it up because jshint was complaining.

[DouweM]

Looks good to me!