Skip to content

Hide stack frames from raven.js #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2014

Conversation

Yogu
Copy link
Contributor

@Yogu Yogu commented May 30, 2014

normalizeFrame() no not only hides stack frames from raven.min.js, but also from raven.js. This is useful if the uncompressed script is used in a development environment.

The parenthesis in the regex make me think that the original author intended to have the .min part optional.

normalizeFrame() no not only hides stack frames from raven.min.js, but also from raven.js. This is useful if the uncompressed script is used in a development environment.
@mattrobenolt
Copy link
Contributor

welp, you're right. I'll write a test to confirm this behavior.

mattrobenolt added a commit that referenced this pull request May 30, 2014
@mattrobenolt mattrobenolt merged commit 0e34652 into getsentry:master May 30, 2014
@Yogu Yogu deleted the hide-raven-stack-frame branch May 30, 2014 20:21
@Yogu
Copy link
Contributor Author

Yogu commented May 30, 2014

Whow, that was quick. Thanks!

@mattrobenolt
Copy link
Contributor

;)

mattrobenolt added a commit that referenced this pull request May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants