feat!: Bump to OpenTelemetry v2 #16872

andreiborza · 2025-07-10T08:22:33Z

This PR

bumps all OpenTelemetry packages to v2 and equivalent (i.e. 0.202.0 for experimental and latest versions for all instrumentations).
removes our vendored express v5 instrumentation in favor of the OpenTelemetry instrumentation
adds polyfills for node utils to vercel-edge
removes the @sentry/opentelemetry OpenTelemetry v2 test dev-package as this is now covered by the package itself

Note: Once this PR is merged, the develop branch officially becomes the v10 branch and any releases for v9 have to happen on the v9 branch.

github-actions · 2025-07-10T08:32:55Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	23.78 kB	-	-
@sentry/browser - with treeshaking flags	22.34 kB	-	-
@sentry/browser (incl. Tracing)	39.66 kB	-	-
@sentry/browser (incl. Tracing, Replay)	77.79 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	67.59 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	82.49 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	94.59 kB	-	-
@sentry/browser (incl. Feedback)	40.48 kB	-	-
@sentry/browser (incl. sendFeedback)	28.46 kB	-	-
@sentry/browser (incl. FeedbackAsync)	33.36 kB	-	-
@sentry/react	25.54 kB	-	-
@sentry/react (incl. Tracing)	41.62 kB	-	-
@sentry/vue	28.23 kB	-	-
@sentry/vue (incl. Tracing)	41.45 kB	-	-
@sentry/svelte	23.81 kB	-	-
CDN Bundle	25.18 kB	-	-
CDN Bundle (incl. Tracing)	39.42 kB	-	-
CDN Bundle (incl. Tracing, Replay)	75.42 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	80.89 kB	-	-
CDN Bundle - uncompressed	73.44 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	116.86 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	231 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	243.81 kB	-	-
@sentry/nextjs (client)	43.66 kB	-	-
@sentry/sveltekit (client)	40.08 kB	-	-
@sentry/node	142.66 kB	-14.99%	-25.15 kB 🔽
@sentry/node - without tracing	91.31 kB	-8.88%	-8.89 kB 🔽
@sentry/aws-serverless	102.75 kB	-19.96%	-25.61 kB 🔽
@sentry/node-core	47.24 kB	added	added

View base workflow run

mydea · 2025-07-10T10:18:27Z

packages/node/test/helpers/mockSdkInit.ts

+
+  // Access the span processors from the provider via _activeSpanProcessor
+  // Casted as any because _activeSpanProcessor is marked as readonly
+  const multiSpanProcessor = (provider as any)._activeSpanProcessor as


not sure, but sometimes it also works to do provider['_activeSpanProcessor'] to make TS happy!

👍 worked, thanks!

mydea

nice work!

Lms24

Nice! I just had a couple of questions regarding changed attributes/data mostly. Otherwise LGTM!

Lms24 · 2025-07-16T10:53:26Z

dev-packages/e2e-tests/test-applications/node-express-cjs-preload/tests/server.test.ts

@@ -65,7 +65,6 @@ test('Should record a transaction for route with parameters', async ({ request }
    data: {
      'express.name': 'query',
      'express.type': 'middleware',
-      'http.route': '/',


logaf-l but our of curiosity: why was this attribute removed?

The express instrumentation doesn't add it anymore to middleware spans, I didn't find anything in their changelog regarding this tho so it's more of an observation after running it 😅.

Actually, this likely came from open-telemetry/opentelemetry-js-contrib#2843. Looks like it might be a bug in the instrumentation now because these spans are not for a 404 route..

@s1gr1d could you take a look at that please?

This was a bug before, as it was always attaching http.route. http.route should not be included when no route was matched (on 404).

The matched route, that is, the path template in the format used by the respective server framework.

Semantic Convention Docs: https://opentelemetry.io/docs/specs/semconv/registry/attributes/http/

But in this case it's not a 404 route 🤔

Just checked: Middleware spans might not include the http.route attribute when it's not yet known at the time the middleware runs. And 'http.route': '/' is only added when there is an explicitly defined root route AND when when the route resolution is already done (middleware might run before that).

And why it was added before: Previously, the attribute ALWAYS defaulted to / but this was wrong. https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2843/files#diff-81c3e13c3dac53e0dd6aabf6dc165305350eb522a85a2561f9ee51d9249011e7L198

Awesome, thanks so much for investigating and fixing this upstream @s1gr1d :)

Lms24 · 2025-07-16T10:54:21Z

dev-packages/e2e-tests/test-applications/node-otel-without-tracing/src/instrument.ts

-    }),
-  ),
-);
+const provider = new NodeTracerProvider({


no action required: was this a breaking change in the provider class or simply a refactor?

Breaking change, there's no more addSpanProcessor in v2.

Lms24 · 2025-07-16T10:56:12Z

...applications/react-router-7-framework-node-20-18/tests/performance/trace-propagation.test.ts

@@ -31,7 +31,11 @@ test.describe('Trace propagation', () => {
    const clientTx = await clientTxPromise;

    expect(clientTx.contexts?.trace?.trace_id).toEqual(serverTx.contexts?.trace?.trace_id);
-    expect(clientTx.contexts?.trace?.parent_span_id).toBe(serverTx.contexts?.trace?.span_id);
+
+    const requestHandlerSpan = serverTx.spans?.find(span => span.op === 'request_handler.express');


no action required: looks like the parent span changed here. Any idea why? Is this a consequence of updated instrumenations?

Yea, this came through the update in instrumentation. We no longer use our express v5 instrumentation.

chargome

🥇

chargome · 2025-07-16T11:21:16Z

packages/nestjs/package.json

-    "@opentelemetry/instrumentation-nestjs-core": "0.44.1",
+    "@opentelemetry/core": "^2.0.0",
+    "@opentelemetry/instrumentation": "^0.202.0",
+    "@opentelemetry/instrumentation-nestjs-core": "0.48.1",


We can then switch this one in a separate PR (replacing our vendored instrumentation)

We have to switch anyway to match deps, it shouldn't affect our vendored instrumentation tho.

… as a devDep

mydea reviewed Jul 10, 2025

View reviewed changes

andreiborza force-pushed the ab/bump-otel-v2 branch 11 times, most recently from 6de3296 to 957a4c8 Compare July 15, 2025 12:46

andreiborza marked this pull request as ready for review July 15, 2025 13:25

andreiborza requested review from Lms24, chargome, RulaKhaled and mydea July 15, 2025 13:26

andreiborza force-pushed the ab/bump-otel-v2 branch 2 times, most recently from 8c43c8a to 213aa83 Compare July 16, 2025 09:29

mydea approved these changes Jul 16, 2025

View reviewed changes

Lms24 approved these changes Jul 16, 2025

View reviewed changes

mydea changed the title ~~feat: Bump to OpenTelemetry v2~~ feat!: Bump to OpenTelemetry v2 Jul 16, 2025

chargome approved these changes Jul 16, 2025

View reviewed changes

andreiborza added 6 commits July 16, 2025 19:09

feat: Bump to OpenTelemetry v2

af01a4f

Replace instrumentation-redis-4 with instrumentation-redis

4b7dbdc

Address breaking changes for Resource and TracerProvider

548f516

Bump node-core-integration-tests OTel deps

7f03d62

Fix nestjs isWrapped import

5ff5379

Adjust @sentry/opentelemetry unit tests for v2

6dd4eee

andreiborza added 22 commits July 16, 2025 19:09

Remove dev-packages/opentelemetry-v2-tests

7450622

Adjust @sentry/node unit tests

65ebc62

Adjust @sentry/node-core unit tests

596833d

Bump OTel in e2e tests

05cf5b2

Remove vendored express v5 instrumentation

c3b9a0c

Avoid casting to any in tests

6370650

Fix e2e/node-express transactions tests

519d154

Make OTel core and sdk-trace-base direct deps of vercel-edge

25ce8eb

Fix e2e/node-express-cjs-preload tests

a153334

Fix e2e/node-express-esm-loader tests

2d22b39

Fix e2e/node-express-esm-preload tests

0668942

Fix e2e/node-otel tests

d47740c

Fix e2e/node-otel-custom-sampler tests

2bb9f0b

Fix e2e/node-otel-sdk-node tests

61cc682

Fix e2e/node-otel-without-tracing tests

0b6a3b1

Add node-core to .size-limit.js and adjust node's size limit

8e418b0

Fix e2e/nextjs-app-dir tests by keeping @opentelemetry/sdk-trace-base…

dcdd570

… as a devDep

Try moving deps back to devDeps

6d56cc0

Try different deps shuffling

17c3708

Try polyfilling nodejs util

909064c

Adjust tests to look at trace continuation via request handler spans

e794500

Extend root route handling integration test, see #16375 for details

2105d24

andreiborza force-pushed the ab/bump-otel-v2 branch from 4f9eeed to 2105d24 Compare July 16, 2025 17:09

Uh oh!

feat!: Bump to OpenTelemetry v2 #16872

Are you sure you want to change the base?

feat!: Bump to OpenTelemetry v2 #16872

Conversation

andreiborza commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mydea left a comment

Choose a reason for hiding this comment

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s1gr1d Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s1gr1d Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chargome left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andreiborza commented Jul 10, 2025 •

edited

Loading

github-actions bot commented Jul 10, 2025 •

edited

Loading

s1gr1d Jul 16, 2025 •

edited

Loading

s1gr1d Jul 16, 2025 •

edited

Loading