fix(nuxt): Ensure order of plugins is consistent#16798
Merged
Conversation
Noticed #16783 in the nuxt-3-min test, that the plugins are not consistently run apparently. In that test, the client integrations plugin was run before the client config plugin, leading to the client not existing yet, and thus not adding the browser tracing integration. This PR changes this to ensure we have a consistent order of these plugins.
andreiborza
approved these changes
Jul 3, 2025
Member
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
Mhm, did this just silently fail before?
mydea
force-pushed
the
fn/ensure-nuxt-plugin-order
branch
from
6281550 to
9fedd69
Compare
Member
Author
|
I think it only fails on specific versions of nuxt or vue or something like this, only the nuxt-3-min test failed on the branch without that 🤔 basically it was just a bit indeterministic, this should be fine hopefully xD |
s1gr1d
reviewed
Jul 7, 2025
Member
s1gr1d
left a comment
s1gr1d
left a comment
There was a problem hiding this comment.
The plugin should already depend on the first one, but maybe dependsOn is not working properly 🤔
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed #16783 in the nuxt-3-min test, that the plugins are not consistently run apparently. In that test, the client integrations plugin was run before the client config plugin, leading to the client not existing yet, and thus not adding the browser tracing integration.
This PR changes this to ensure we have a consistent order of these plugins.