feat(node): Expand how vercel ai input/outputs can be set #16455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
requested review from
a team,
stephanie-anderson and
s1gr1d
and removed request for
a team
Lms24
reviewed
Jun 3, 2025
| }; | ||
| } | ||
| const client = getCurrentScope().getClient(); | ||
| const shouldRecordImportAndExports = client?.getIntegrationByName(INTEGRATION_NAME) |
There was a problem hiding this comment.
l: shouldn't this rather be named
Suggested change
| const shouldRecordImportAndExports = client?.getIntegrationByName(INTEGRATION_NAME) | |
| const shouldRecordInputsAndOutputs = client?.getIntegrationByName(INTEGRATION_NAME) |
?
There was a problem hiding this comment.
super-l: Is there a reason for this file? No strong feelings, so feel free to disregard but I'd rather avoid a constants file with one export.
There was a problem hiding this comment.
I put this here to avoid circular imports (instrumentation -> index)
There was a problem hiding this comment.
ahh that's of course fine! sorry, didn't notice it
AbhiPrasad
force-pushed
the
abhi-send-default-pii-vercel-ai
branch
from
e23162f to
71e7546
Compare
Lms24
approved these changes
Jun 4, 2025
AbhiPrasad
changed the title
sendDefaultPii is true
❌ Unsupported file format
|
6 tasks
AbhiPrasad
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 8, 2025
## DESCRIBE YOUR PR Documents getsentry/sentry-javascript#16455 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [x] Urgent deadline (GA date, etc.): June 9 (we need this to be ready by June 11, but we should merge before then) - [ ] Other deadline: <!-- ENTER DATE HERE --> - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #16452
Based on feedback, we want to enable attaching prompts (inputs/outputs) to vercel AI spans if
sendDefaultPiiistrue.We also add new integration options to the Vercel AI integration that allows you to override this.
Usage: