fix(node): Revert to using upstream @fastify/otel instrumentation#16320
Closed
andreiborza wants to merge 1 commit intodevelopfrom
Closed
fix(node): Revert to using upstream @fastify/otel instrumentation#16320andreiborza wants to merge 1 commit intodevelopfrom
@fastify/otel instrumentation#16320andreiborza wants to merge 1 commit intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
Closing this after some discussions in the team as it would just replace one problem with another one. We'll wait for the fork being vendored in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #16256 we switched from upstream
@fastify/otelto a Otel v1 downgraded fork to ensure dependencies are aligned with our node sdk.This PR will re-introduce a warning about unmet dependencies #16245 for the time being.