Skip to content

test(node): Add utility to test esm & cjs instrumentation #16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 30, 2025
Merged

test(node): Add utility to test esm & cjs instrumentation #16159

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c9a0e08
test(node): Add utility to test esm & cjs instrumentation
mydea Apr 28, 2025
88eee44
add more tests
mydea Apr 29, 2025
fb38aed
WIP
mydea Apr 30, 2025
6d1a73c
update ai test
mydea Apr 30, 2025
4e41faf
update timeout
mydea Apr 30, 2025
68ac69e
increase anr timeout
mydea Apr 30, 2025
616c391
rename to failsOnEsm
mydea Apr 30, 2025
68d0733
genericPool
mydea Apr 30, 2025
d058fa8
httpIntegration
mydea Apr 30, 2025
05e2692
kafkajs
mydea Apr 30, 2025
1175539
always create files even if cjs is skipped
mydea Apr 30, 2025
fffc2c2
remove one level of nesting of describe calls
mydea Apr 30, 2025
3d9ce14
knex
mydea Apr 30, 2025
410cecf
cleanup unneeded comments/vars
mydea Apr 30, 2025
2804ee5
move cjs creation to beforeAll
mydea Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
always create files even if cjs is skipped
  • Loading branch information
@mydea
mydea committed Apr 30, 2025
commit 117553911307cc380ee7b7d211fa3b7c43b3d33c
6 changes: 2 additions & 4 deletions dev-packages/node-integration-tests/utils/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,8 @@ export function createEsmAndCjsTests(
const cjsInstrumentPath = join(cwd, `tmp_${instrumentPath.replace('.mjs', '.cjs')}`);

// For the CJS runner, we create some temporary files...
if (!options?.failsOnCjs) {
convertEsmFileToCjs(mjsScenarioPath, cjsScenarioPath);
convertEsmFileToCjs(mjsInstrumentPath, cjsInstrumentPath);
}
convertEsmFileToCjs(mjsScenarioPath, cjsScenarioPath);
convertEsmFileToCjs(mjsInstrumentPath, cjsInstrumentPath);

describe('esm & cjs', () => {
afterAll(() => {
Expand Down