Skip to content

perf(nestjs): Remove usage of addNonEnumerableProperty #15766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

perf(nestjs): Remove usage of addNonEnumerableProperty #15766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24f7dda
perf(nestjs): Remove usage of addNonEnumerableProperty
AbhiPrasad Mar 21, 2025
c130c5b
Update packages/nestjs/src/integrations/sentry-nest-instrumentation.ts
AbhiPrasad Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/nestjs/src/integrations/sentry-nest-instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
import type { Span } from '@sentry/core';
import {
SDK_VERSION,
addNonEnumerableProperty,
getActiveSpan,
isThenable,
startInactiveSpan,
Expand Down Expand Up @@ -90,7 +89,9 @@ export class SentryNestInstrumentation extends InstrumentationBase {
/**
* Creates a wrapper function for the @Injectable decorator.
*/
private _createWrapInjectable() {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
private _createWrapInjectable(): (original: any) => (options?: unknown) => (target: InjectableTarget) => any {
const SeenNestjsContextSet = new WeakSet<MinimalNestJsExecutionContext>();
// eslint-disable-next-line @typescript-eslint/no-explicit-any
return function wrapInjectable(original: any) {
return function wrappedInjectable(options?: unknown) {
Expand Down Expand Up @@ -197,8 +198,8 @@ export class SentryNestInstrumentation extends InstrumentationBase {
return withActiveSpan(parentSpan, () => {
const handleReturnObservable = Reflect.apply(originalHandle, thisArgHandle, argsHandle);

if (!context._sentryInterceptorInstrumented) {
addNonEnumerableProperty(context, '_sentryInterceptorInstrumented', true);
if (!SeenNestjsContextSet.has(context)) {
SeenNestjsContextSet.add(context);
afterSpan = startInactiveSpan(
getMiddlewareSpanOptions(target, 'Interceptors - After Route'),
);
Expand All @@ -209,8 +210,8 @@ export class SentryNestInstrumentation extends InstrumentationBase {
} else {
const handleReturnObservable = Reflect.apply(originalHandle, thisArgHandle, argsHandle);

if (!context._sentryInterceptorInstrumented) {
addNonEnumerableProperty(context, '_sentryInterceptorInstrumented', true);
if (!SeenNestjsContextSet.has(context)) {
SeenNestjsContextSet.add(context);
afterSpan = startInactiveSpan(getMiddlewareSpanOptions(target, 'Interceptors - After Route'));
}

Expand Down
Loading