Skip to content

profiling: implement new profiling API spec #15636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2025
Merged

profiling: implement new profiling API spec #15636

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f53d05
profiling: initialize client
JonasBa Mar 11, 2025
0e5e2a5
profiling: add check to lifecycle start and stop methods
JonasBa Mar 11, 2025
86b1b63
profiling: add implementation comment
JonasBa Mar 11, 2025
512254f
profiling: add trace profiling
JonasBa Mar 12, 2025
d6a20ab
disable deprecation errors
JonasBa Mar 12, 2025
7179648
disable deprecation errors
JonasBa Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
profiling: add check to lifecycle start and stop methods
  • Loading branch information
@JonasBa
JonasBa committed Mar 11, 2025
commit 0e5e2a5262783e8a96ad70ea277ff53b3786e458
18 changes: 16 additions & 2 deletions packages/profiling-node/src/integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,22 @@ class ContinuousProfiler {
this._teardownSpanChunkInstrumentation();
}

public startProfileSession(): void {}
public stopProfileSession(): void {}
public startProfileSession(): void {
if (this._mode !== 'current') {
DEBUG_BUILD && logger.log('[Profiling] Continuous profiling is not supported in the current mode.');
return;
}

// @TODO: Implement
}
public stopProfileSession(): void {
if (this._mode !== 'current') {
DEBUG_BUILD && logger.log('[Profiling] Continuous profiling is not supported in the current mode.');
return;
}

// @TODO: Implement
}

/**
* Stop profiler and initializes profiling of the next chunk
Expand Down