Skip to content

fix(nextjs): Use batched devserver symbolication endpoint #15335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Feb 7, 2025

Fixes #15308

@lforst lforst requested a review from chargome February 7, 2025 08:13
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice, thanks for fixing!

@lforst lforst merged commit cbc9da9 into develop Feb 7, 2025
46 checks passed
@lforst lforst deleted the lforst-fix-dev-error-symbolication branch February 7, 2025 08:29
@heca-frantisek
Copy link

heca-frantisek commented Mar 22, 2025

is it possible this implementation is wrong?
in my Next v15.3
i am having a problem that on any sentry/nextjs::captureException() in my app router page.tsx
this devErrorSymbolicationEventProcessor is fired
inside the globalWithInjectedValues.next?.version is not defined at all, hence it's 0.0.0
then in the "version logic" it falls to the resolveStackFrame()
which calls the __nextjs_original-stack-frame as a GET

but the Next middleware-webpack.ts::getOverlayMiddleware(options) does handle only this logic:

if (pathname === '/__nextjs_original-stack-frames') {
            if (req.method !== 'POST') {

and this is not triggered and all these __nextjs_original-stack-frame fetches do fall to my application logic :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[next] Update stackframe resolving in dev mode
3 participants