-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(node): Capture exceptions from worker_threads
#15105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
worker_threads
childProcessIntegration
Tests
…ry/sentry-javascript into timfish/feat/child-process-extra
childProcessIntegration
Testsworker_threads
size-limit report 📦
|
…ry/sentry-javascript into timfish/feat/child-process-extra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the events captured from worker_threads
get the correct trace id attached to them?
I wonder if we should be propagating the trace context to the worker threads scope with this integration as well 🤔
Currently this works even without Sentry running in the worker thread and because it uses |
Let's open a draft PR for this in the docs, we can only merge it in when we release v9 though. I don't think we should backport this, we can make it a new feature for v9+ |
Updates the
childProcessIntegration
to captureworker_threads
errors (including their stack traces) rather than capturing a breadcrumb.This features is enabled by default and can be disabled by setting the
captureWorkerErrors
option tofalse
:When
captureWorkerErrors: false
, a breadcrumb will be captured instead.This PR also adds more integration tests for the
childProcessIntegration
.