feat(solidstart): Respect user-provided source map setting #14979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Jan 10, 2025
| // Only if source maps were previously not set, we update the "filesToDeleteAfterUpload" (as we override the setting with "hidden") | ||
| typeof viteConfig.build?.sourcemap === 'undefined' | ||
| ) { | ||
| // This also works for adapters, as the source maps are also copied to e.g. the .vercel folder |
There was a problem hiding this comment.
l: any chance this comment is from astro (not sure if solid start has adapters)? :)
| }); | ||
| } | ||
|
|
||
| return [ |
There was a problem hiding this comment.
l: If we only return sentryVitePlugin() here, we don't need to spread the plugins into a new array but can simply return the call directly.
There was a problem hiding this comment.
This was done to make it easier to add more plugins if we ever need, but I guess we can cross that bridge then :)
…rcemaps-hidden # Conflicts: # docs/migration/v8-to-v9.md
lforst
reviewed
Jan 13, 2025
| typeof viteConfig.build?.sourcemap === 'undefined' | ||
| ) { | ||
| // This also works for adapters, as the source maps are also copied to e.g. the .vercel folder | ||
| updatedFilesToDeleteAfterUpload = ['.*/**/*.map']; |
There was a problem hiding this comment.
Suggested change
| updatedFilesToDeleteAfterUpload = ['.*/**/*.map']; | |
| updatedFilesToDeleteAfterUpload = ['./**/*.map']; |
Unless this is intentional?
There was a problem hiding this comment.
This is intentional. It should match .output, .vercel, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13994