Skip to content

feat(node)!: Remove processThreadBreadcrumbIntegration #14666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2024
Merged

feat(node)!: Remove processThreadBreadcrumbIntegration #14666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06a0b2d
feat(node): Remove `processThreadBreadcrumbIntegration`
lforst Dec 11, 2024
01bcd7b
Merge branch 'v9' into lforst-rm-ptbi
lforst Dec 12, 2024
9bb0d4f
fix
lforst Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ const DEPENDENTS: Dependent[] = [
ignoreExports: [
// not supported in bun:
'NodeClient',
// Bun doesn't emit the required diagnostics_channel events
'processThreadBreadcrumbIntegration',
'childProcessIntegration',
],
},
Expand Down
2 changes: 0 additions & 2 deletions packages/astro/src/index.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ export {
parameterize,
postgresIntegration,
prismaIntegration,
// eslint-disable-next-line deprecation/deprecation
processThreadBreadcrumbIntegration,
childProcessIntegration,
redisIntegration,
requestDataIntegration,
Expand Down
2 changes: 0 additions & 2 deletions packages/aws-serverless/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ export {
setupNestErrorHandler,
postgresIntegration,
prismaIntegration,
// eslint-disable-next-line deprecation/deprecation
processThreadBreadcrumbIntegration,
childProcessIntegration,
hapiIntegration,
setupHapiErrorHandler,
Expand Down
2 changes: 0 additions & 2 deletions packages/google-cloud-serverless/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@ export {
zodErrorsIntegration,
profiler,
amqplibIntegration,
// eslint-disable-next-line deprecation/deprecation
processThreadBreadcrumbIntegration,
childProcessIntegration,
} from '@sentry/node';

Expand Down
3 changes: 1 addition & 2 deletions packages/node/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ export { tediousIntegration } from './integrations/tracing/tedious';
export { genericPoolIntegration } from './integrations/tracing/genericPool';
export { dataloaderIntegration } from './integrations/tracing/dataloader';
export { amqplibIntegration } from './integrations/tracing/amqplib';
// eslint-disable-next-line deprecation/deprecation
export { processThreadBreadcrumbIntegration, childProcessIntegration } from './integrations/childProcess';
export { childProcessIntegration } from './integrations/childProcess';

export { SentryContextManager } from './otel/contextManager';
export { generateInstrumentOnce } from './otel/instrument';
Expand Down
7 changes: 0 additions & 7 deletions packages/node/src/integrations/childProcess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,6 @@ export const childProcessIntegration = defineIntegration((options: Options = {})
};
});

/**
* Capture breadcrumbs for child processes and worker threads.
*
* @deprecated Use `childProcessIntegration` integration instead. Functionally they are the same. `processThreadBreadcrumbIntegration` will be removed in the next major version.
*/
export const processThreadBreadcrumbIntegration = childProcessIntegration;

function captureChildProcessEvents(child: ChildProcess, options: Options): void {
let hasExited = false;
let data: Record<string, unknown> | undefined;
Expand Down
Loading