Skip to content

fix(react): align Error Boundary componentStack typing with React.Err… #14327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kunal-511
Copy link

@kunal-511 kunal-511 commented Nov 16, 2024

…orInfo

Fixed ErrorBoundary componentStack type in @sentry/react to use React.ErrorInfo['componentStack']

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for opening a PR!

This also involves changing ErrorBoundaryState as well as onReset lifecycle methods, which makes this a breaking change.

Let's revisit this when we start working on v9!

@AbhiPrasad
Copy link
Member

I've opened #14742 for this change, so closing this PR. Thanks for contributing though - I've left you a shoutout in the changelog of our repo!

@AbhiPrasad AbhiPrasad closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants